Conversation
Apache9
reviewed
Sep 16, 2026
| * @return the hbase version string, eg. "0.6.3-dev" | ||
| */ | ||
| public static String getVersion() { | ||
| return version; |
Contributor
Author
There was a problem hiding this comment.
This mutable field was introduced only to let the test override the version through reflection. Since the test now simulates the lower version through HMaster, the field is no longer needed, so getVersion() can return Version.version directly again.
Contributor
There was a problem hiding this comment.
This is the only place where we override this field by reflection?
Contributor
Author
There was a problem hiding this comment.
Yes. I checked the repository, and TestRSGroupsKillRS#setVersionInfoVersion is the only place that modifies VersionInfo.version through reflection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Split the mixed-version scenario into
TestRSGroupsKillRSWithDifferentVersions. Use a testHMasterimplementation to report a lower version for the target RegionServer, and restoreVersionInfo#getVersionto return the generated version directly.Why are the changes needed?
The existing test changes process-wide
VersionInfostate through reflection. Since MiniCluster components run in the same JVM, this may affect unrelated servers and requires production code to keep mutable state only for testing.How was this patch tested?